Add compile-time checks for the "matches" operator #4330
+32
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
force-pushed
the
matches-detect-issues-at-compile-time
branch
2 times, most recently
from
04f1839
to
3e4bcdc
Compare
fabpot
force-pushed
the
matches-detect-issues-at-compile-time
branch
from
3e4bcdc
to
d1beac4
Compare
Kocal
reviewed
Sep 21, 2024
| { | ||
| if ($right instanceof ConstantExpression) { | ||
| $regexp = $right->getAttribute('value'); | ||
| set_error_handler(static fn ($t, $m) => throw new SyntaxError(\sprintf('Regexp "%s" passed to "matches" is not valid: %s.', $regexp, substr($m, 14)), $lineno)); |
There was a problem hiding this comment.
The number 14 feels like a bit magical to me, can we add a comment or use strlen('...') (which will be inlined to 14) instead?
There was a problem hiding this comment.
This also somehow doesn't look right:
Twig\Error\RuntimeError: Regexp "3" passed to "matches" is not valid: Delimiter must not be alphanumeric%sbackslash%sin "index.twig" at line 2
It seems like there's at least a space missing before in "index.twig" at line 2.
There was a problem hiding this comment.
The message is correct, here, this is only the format to cover differences between PHP versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.