Merged
Conversation
vilgotf
force-pushed
the
vilgotf/app-id
branch
4 times, most recently
from
b1f7483 to
c993029
Compare
Statically defining the application ID seems odd to most users. Additional changes: - rename some items - replace `Ok::<_, anyhow::Error>` with `anyhow::Ok`
vilgotf
force-pushed
the
vilgotf/app-id
branch
from
c993029 to
a2ae75e
Compare
Erk-
approved these changes
Feb 18, 2026
vilgotf
added a commit
that referenced
this pull request
Feb 18, 2026
Statically defining the application ID seems odd to most users. Additional changes: - rename some items - replace `Ok::<_, anyhow::Error>` with `anyhow::Ok`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Statically defining the application ID seems odd to most users.
Additional changes:
Ok::<_, anyhow::Error>withanyhow::Ok