Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for PS256, RS256 PKCV in validationClient #759

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

kridai
Copy link
Contributor

@kridai kridai commented Aug 16, 2023

Fixes

Closes https://issues.corp.twilio.com/browse/DII-1072.
Previously, public key client validation (PKCV) only allowed RS256 algorithms to be used. This change is to support PS256 algorithm as well.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

71.4% 71.4% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@kridai kridai requested a review from sbansla August 18, 2023 07:39
@kridai kridai merged commit 7cde0bf into main Aug 23, 2023
12 of 13 checks passed
@kridai kridai deleted the pkcv-changes branch August 23, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants