add missing endpoints #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emilgardis
commented
Nov 17, 2023
| /// * `1000` — First level of paid or Prime subscription | ||
| /// * `2000` — Second level of paid subscription | ||
| /// * `3000` — Third level of paid subscription | ||
| pub sub_tier: types::SubscriptionTier, |
There was a problem hiding this comment.
this is technically wrong, twitch_types::SubscriptionTier includes prime
Emilgardis
commented
Nov 17, 2023
| } | ||
|
|
||
| /// Deserialize {"field": field} as { field ...} and serialize in reverse | ||
| mod enum_field_as_inner { |
There was a problem hiding this comment.
Im not sure about this name.
Also, I think i can use this for eventsub and pubsub deser instead of macro trickery, will investigate
Emilgardis
force-pushed
the
random-stuff
branch
3 times, most recently
from
42b5725 to
d1ed419
Compare
|
forgot to actually test .notification :) |
Emilgardis
commented
Nov 21, 2023
will continue improving later
still some stuff to do though, want it to be an enum
Emilgardis
force-pushed
the
random-stuff
branch
from
40e337f to
eaab872
Compare
|
This should be ready, just need .message implemented in #399 I heavily dislike the ad schedule related endpoints, they should never have been released in GA... |
Emilgardis
force-pushed
the
random-stuff
branch
from
eaab872 to
ef80da5
Compare
Emilgardis
force-pushed
the
random-stuff
branch
2 times, most recently
from
7555ef7 to
6228ff9
Compare
Emilgardis
force-pushed
the
random-stuff
branch
from
6228ff9 to
81b4b55
Compare
feat(eventsub): add `channel.chat.message`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice :)