Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi nested inheritance of the same parent #196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbrey
Copy link

@jbrey jbrey commented Jun 27, 2014

This request provides the support for nesting the same parent and redefining the parents section several times in the same template.

This allows for instance to reuse a template which defines a container with a content region and nest the containers.

Example:

Hogan.compile( '{{<parent}}{{$region}}a{{<parent}}{{$region}}b{{/region}}{{/parent}}{{/region}}{{/parent}}').render({}, {
parent: '...{{$region}}{{/region}}.'
});

Will render:

...a...b..

Basically the compiler associates the nested level to the subs’ code in the generated objects and the template takes into account this level to decide which sub should be used.

This adds also compliance with java implementation that does not fail on these use cases.
I add also three tests in order to demonstrate and test the behavior.

I am using the same template on both server side and ui side, that’s why I need to have this working on both sides.

JB

@sayrer
Copy link
Collaborator

sayrer commented Jun 27, 2014

Thanks for the patch and tests. This might take a while... I'll need to confer with other mustache implementors.

@rafaell-lycan
Copy link

up

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


jbrey seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants