Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support of script load command by broadcast #424

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

umegaya
Copy link

@umegaya umegaya commented Oct 21, 2015

refs #68
this pull request aims to add support for SCRIPT LOAD command, by following fix.

  • define msg type for SCRIPT LOAD and parse correctly (8158d2e)
  • able to give 'broadcast' attribute to certain kind of msg type, and give broadcast attribute to SCRIPT command (8158d2e)
  • do broadcast correctly (cb50953)

also original python test seems to be broken, add new test by shell script (dfba9f8), you can run new test like following:

cd tests/test_redis_sh
./run ./test_script_load.sh

it is only passed limited test case, and I'm very new to twemproxy, so not enough confidence about correctness. can you review and if it looks good, merge to master? thanks in advance.

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants