Skip to content

Nullable requesthandler #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twogood merged 10 commits into from
Oct 28, 2025
Merged

Nullable requesthandler #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2f98349
Make RestClientContext a `record` and move logic to RestClientBuilder
twogood Oct 25, 2025
7395441
Coderabbit nitpicking
twogood Oct 25, 2025
055ad6a
Fix more Coderabbit feedback
twogood Oct 25, 2025
6af8de3
Merge remote-tracking branch 'origin/main' into nullable-requesthandler
twogood Oct 25, 2025
9e8c473
Nullable RequestHandler
twogood Oct 27, 2025
1ea457f
Handle Coderabbit feedback
twogood Oct 27, 2025
ddd26cb
Improve test naming
twogood Oct 27, 2025
1ce31be
Safer iteration of array parameter
twogood Oct 27, 2025
3c090cd
Thank you Coderabbit!
twogood Oct 28, 2025
e25ed1d
Use braces
twogood Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions ...estClient.Newtonsoft.Json.Test/DomainExceptions/DefaultDomainExceptionErrorObjectTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,41 +66,40 @@ public async Task TestMapApiErrorObject()
}

[Theory]
[InlineData(HttpStatusCode.BadRequest, MyDomainErrorEnum.ClientError)]
[InlineData(HttpStatusCode.BadGateway, MyDomainErrorEnum.ServerError)]
public async Task TestDeserializerException(HttpStatusCode httpStatusCode, MyDomainErrorEnum error)
[InlineData(HttpStatusCode.BadRequest)]
[InlineData(HttpStatusCode.BadGateway)]
public async Task TestDeserializerException(HttpStatusCode httpStatusCode)
{
// Arrange
_mockHttp
.Expect(BaseUri)
.Respond(_ => HtmlHttpResponseMessage(httpStatusCode));

// Act
var exception = await Assert.ThrowsAsync<SomeDomainErrorObjectException>(() =>
var exception = await Assert.ThrowsAsync<RestClientException>(() =>
_defaultMapperApiClient.Api());

// Assert
Assert.Equal(error, exception.Error);
Assert.Equal(httpStatusCode, exception.StatusCode);
Assert.IsType<MissingMethodException>(exception.InnerException);
}

[Theory]
[InlineData(HttpStatusCode.BadRequest, MyDomainErrorEnum.ClientError)]
[InlineData(HttpStatusCode.BadGateway, MyDomainErrorEnum.ServerError)]
public async Task TestNoDeserializerFound(HttpStatusCode httpStatusCode, MyDomainErrorEnum error)
[InlineData(HttpStatusCode.BadRequest)]
[InlineData(HttpStatusCode.BadGateway)]
public async Task TestNoDeserializerFound(HttpStatusCode httpStatusCode)
{
// Arrange
_mockHttp
.Expect(BaseUri)
.Respond(_ => FoobarHttpResponseMessage(httpStatusCode));

// Act
var exception = await Assert.ThrowsAsync<SomeDomainErrorObjectException>(() =>
var exception = await Assert.ThrowsAsync<RestClientException>(() =>
_defaultMapperApiClient.Api());

// Assert
Assert.Equal(error, exception.Error);
Assert.IsType<RestClientException>(exception.InnerException);
Assert.Equal(httpStatusCode, exception.StatusCode);
}

private static HttpResponseMessage JsonHttpResponseMessage(HttpStatusCode httpStatusCode, MyApiError myApiError)
Expand Down
6 changes: 3 additions & 3 deletions Activout.RestClient.Newtonsoft.Json.Test/DomainExceptions/DomainExceptionErrorObjectTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,19 +102,19 @@ public async Task TestMapApiErrorObject()
}

[Fact]
public async Task TestNoDeserializerFound()
public async Task TestErrorResponseNotCompatibleWithHtml()
{
// Arrange
_mockHttp
.Expect(BaseUri)
.Respond(_ => HtmlHttpResponseMessage(HttpStatusCode.BadRequest));

// Act
var exception = await Assert.ThrowsAsync<MyDomainErrorObjectException>(() =>
var exception = await Assert.ThrowsAsync<RestClientException>(() =>
_myApiClient.Api());

// Assert
Assert.Equal(MyDomainErrorEnum.Unknown, exception.Error.ErrorEnum);
Assert.Equal(HttpStatusCode.BadRequest, exception.StatusCode);
Assert.IsType<MissingMethodException>(exception.InnerException);
}

Expand Down
Loading