Skip to content

Add 'UNSHIELD_ASSERT'.#208

Merged
twogood merged 3 commits intotwogood:mainfrom
kratz00:unshield_assert
Feb 8, 2026
Merged

Add 'UNSHIELD_ASSERT'.#208
twogood merged 3 commits intotwogood:mainfrom
kratz00:unshield_assert

Conversation

@kratz00
Copy link
Contributor

@kratz00 kratz00 commented Jan 28, 2026

Apart from deciding what to do about the failing test, I'm thinking that we could have an unshield_assert macro that just calls assert in DEBUG but has our own implementation (a copy of assert?) otherwise?

@twogood something like this?

Signed-off-by: Steffen Pankratz <kratz00@gmx.de>
twogood added a commit that referenced this pull request Jan 28, 2026
twogood added a commit that referenced this pull request Jan 28, 2026
* Fix some warnings

* Disable stack_memory_file test for now

* Wait with -Werror until after #208

---------

Signed-off-by: David Eriksson <david@activout.se>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@kratz00
Copy link
Contributor Author

kratz00 commented Feb 6, 2026

ping @twogood

#204 or this? I have them in draft state, as the how is still under discussion.

@twogood
Copy link
Owner

twogood commented Feb 6, 2026

Sorry for the varying responsiveness from myself!

@twogood
Copy link
Owner

twogood commented Feb 8, 2026

@kratz00 I like this a lot, ok to merge for you?

@kratz00 kratz00 marked this pull request as ready for review February 8, 2026 14:18
@kratz00
Copy link
Contributor Author

kratz00 commented Feb 8, 2026

Thanks. Sure, feel free to merge it.

@twogood twogood merged commit 5f0b6e4 into twogood:main Feb 8, 2026
6 checks passed
@twogood
Copy link
Owner

twogood commented Feb 8, 2026

Thanks for the help!

@kratz00 kratz00 deleted the unshield_assert branch February 8, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants