Skip to content

Fix warnings and disable stack_memory_file test for now @twogood#209

Merged
twogood merged 5 commits intomainfrom
fix-warnings
Jan 28, 2026
Merged

Fix warnings and disable stack_memory_file test for now @twogood#209
twogood merged 5 commits intomainfrom
fix-warnings

Conversation

@twogood
Copy link
Owner

@twogood twogood commented Jan 28, 2026

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to address compiler warnings and temporarily disable a problematic test while tightening CI compilation flags.

Changes:

  • Comments out the v5/stack_memory_file test subdirectory from the CTest configuration.
  • Modifies unshield_utf16_to_utf8 in lib/helper.c to remove an unused variable when calling utf16_to_utf8.
  • Updates the GitHub Actions CMake workflow to attempt to enable -Wall -Werror during CI builds.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
test/CMakeLists.txt Disables the v5/stack_memory_file test suite by commenting out its subdirectory inclusion.
lib/helper.c Adjusts UTF-16 to UTF-8 conversion helper to allocate directly into string_buffer->string and remove an unused result variable, but introduces a malformed utf16_to_utf8 call.
.github/workflows/cmake.yml Attempts to enforce -Wall -Werror via a new CFLAGS cache variable in the CMake configure step, though it is not currently wired into the CMake build.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@twogood
Copy link
Owner Author

twogood commented Jan 28, 2026

Haha, embarrassing, tried to get help from Copilot...

twogood and others added 3 commits January 28, 2026 20:42
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: David Eriksson <david@activout.se>
@twogood twogood merged commit b3d537c into main Jan 28, 2026
11 checks passed
@twogood twogood deleted the fix-warnings branch January 28, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant