Skip to content

Fix compiler warning: ignoring return value of ‘realpath’#215

Merged
twogood merged 2 commits intotwogood:mainfrom
kratz00:fix_warning
Feb 17, 2026
Merged

Fix compiler warning: ignoring return value of ‘realpath’#215
twogood merged 2 commits intotwogood:mainfrom
kratz00:fix_warning

Conversation

@kratz00
Copy link
Contributor

@kratz00 kratz00 commented Feb 17, 2026

No description provided.

Signed-off-by: Steffen Pankratz <kratz00@gmx.de>
Signed-off-by: Steffen Pankratz <kratz00@gmx.de>
Copy link
Owner

@twogood twogood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice way of adding -Werror but still allowing the realpath stuff!

@kratz00
Copy link
Contributor Author

kratz00 commented Feb 17, 2026

Thanks, but we both know the realpath stuff is hacky, it's not really portable - but this is a problem for another day 😄

@kratz00 kratz00 marked this pull request as ready for review February 17, 2026 19:03
@twogood
Copy link
Owner

twogood commented Feb 17, 2026

Thanks, but we both know the realpath stuff is hacky, it's not really portable - but this is a problem for another day 😄

Yeah, I did start to try to actually fix it, something like:

  real_output_directory = realpath(output_directory, real_output_directory);
  real_filename = realpath(filename, real_filename);

But as you say, it is a problem for another day!

@twogood twogood merged commit e983a20 into twogood:main Feb 17, 2026
6 checks passed
@kratz00 kratz00 deleted the fix_warning branch February 17, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments