Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use new interpolator in pyuvdata #25

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

tyler-a-cox
Copy link
Owner

No description provided.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.06%. Comparing base (6e1be35) to head (04fd317).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   93.12%   92.06%   -1.06%     
==========================================
  Files           4        4              
  Lines         189      189              
  Branches       44       44              
==========================================
- Hits          176      174       -2     
- Misses          7        8       +1     
- Partials        6        7       +1     
Flag Coverage Δ
unittests 92.06% <ø> (-1.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tyler-a-cox tyler-a-cox marked this pull request as ready for review September 9, 2024 15:52
Copy link
Collaborator

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'd probably change the default to az_za_map_coordinates though. We'll probably change that to be default on pyuvdata at some point, and there's not a precedent you have to think about here.

@tyler-a-cox tyler-a-cox merged commit 914247e into main Sep 9, 2024
7 checks passed
@tyler-a-cox tyler-a-cox deleted the use_new_interpolator branch September 9, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants