Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow option for users to run a numba-based interpolator that scales with number of cores #28

Closed
wants to merge 13 commits into from

Conversation

tyler-a-cox
Copy link
Owner

No description provided.

@steven-murray
Copy link
Collaborator

@tyler-a-cox this is great!

Here's some thoughts:

  1. We should probably write our own fast_interp unless we want to support that package ourselves into the future (which sounds difficult)
  2. The interface to matvis in the tests obviously needs to be updated
  3. I do wonder if we could do better by putting a simple multiprocess map (or mpi map or whatever) outside the time-loop. Everything within is embarrasingly parallel, so I would guess that the overhead would not be significant, especially for a long-time-axis simulation. We could even try to do the best of both worlds, so have an outer map and let each subprocess have two cores, which maximises the core-to-speedup ratio for each subtask.

@tyler-a-cox
Copy link
Owner Author

Closing this in favor of #29

@tyler-a-cox tyler-a-cox closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants