Update Profile.js to reflect new Firebase req's#40
Open
mintymac wants to merge 1 commit intotylermcginnis:05-reactfirefrom
Open
Update Profile.js to reflect new Firebase req's#40mintymac wants to merge 1 commit intotylermcginnis:05-reactfirefrom
mintymac wants to merge 1 commit intotylermcginnis:05-reactfirefrom
Conversation
|
@mintymac This would be a good suggestion if this repository was not confined to the existing video series. In the video series, specific version of dependencies are installed in order to future proof the recorded material. This PR would also break this version of the application because it is currently restricted to 2.X.X versions of Firebase in package.json. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://firebase.google.com/docs/web/setup#add_firebase_to_your_app