Update addon generator to support sourcemaps. #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set the correct default in the `tsconfig.json` blueprint. - Add a note in the README with details on how to enable support for sourcemaps in Ember CLI/Babel.
dfreeman
reviewed
Feb 20, 2018
README.md
Outdated
| babel: { | ||
| sourceMaps: 'inline', | ||
| } | ||
| } |
chriskrycho
changed the title
|
The option is also documented at https://github.com/babel/ember-cli-babel#enabling-source-maps I'm surprised source maps work at all without running into ef4/fast-sourcemap-concat#39. Maybe the tsc output works around whatever bug causes babel to output invalid source maps? Is there any performance impact enabling this? I'm not so concerned with typescript's performance but rather the rest of the broccoli pipeline. |
|
@dwickern there's definitely a perf hit on the Babel side, though we were already paying that—and I added a note in the README to that effect. Running it locally, TS's generation of source maps seems to have little to no impact, which is nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsconfig.jsonblueprint.Resolves #129.