Skip to content

Add port validation to connection address #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Add port validation to connection address #891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/module/connection/create/connection-creator.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,17 @@ const connectionUrlValidator: ValidatorFn = (control: AbstractControl<string>) =
};

const addressValidator: ValidatorFn = (control: AbstractControl<string>) => {
if (control.value.startsWith(`http://`) || control.value.startsWith(`https://`)) return null;
else return { errorText: `Please specify http:// or https://` };
const value = control.value;
if (!value.startsWith(`http://`) && !value.startsWith(`https://`)) {
return { errorText: `Please specify http:// or https://` };
}
// Check for port format: http(s)://<address>:<port>
// Match http(s):// followed by address content, then :port (digits)
const portPattern = /^https?:\/\/.+:\d+/;
if (!portPattern.test(value)) {
return { errorText: `Format: http(s)://<address>:<port>` };
}
return null;
}

@Component({
Expand Down