Fallback IOLocal#unsafeThreadLocal by a true ThreadLocal#4200
Closed
armanbilge wants to merge 2 commits intotypelevel:series/3.xfrom
Closed
Fallback IOLocal#unsafeThreadLocal by a true ThreadLocal#4200armanbilge wants to merge 2 commits intotypelevel:series/3.xfrom
IOLocal#unsafeThreadLocal by a true ThreadLocal#4200armanbilge wants to merge 2 commits intotypelevel:series/3.xfrom
Conversation
Member
|
This is pretty evil. :( Also remember the only way you could get an |
Member
Author
|
We decided it's too evil.
We are going to do this instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr is that for the
IOLocalContextStoragein typelevel/otel4s#214 to work for arbitrary Java libraries, it must properly implement theContextStorageAPI even when used in a context outside ofIOFiber. To accomplish this, we can makeThreadLocals returned byIOLocal#unsafeThreadLocalbehave as a trueThreadLocalwhen used outside of anIOFiber. This is not currently possible to implement in userland because there is no way to know if you are currently running in a fiber or not.