-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
Did the test pass locally for you? Fails on CI. |
@huntc i was running the sbt-js-module scripted tests, not the local tests -- I confused the webjars-npm with the typesafe-npm.
I think the "undefined" value for npm is where it breaks down. That looks like it's happening from the JS engine, which is configured for Trireme, but I don't know the Node version: https://github.com/typesafehub/js-engine/blob/master/build.sbt#L11 Am currently wondering if Node is out of date is respect to NPM -- from release notes it looks like Node 4.2.4 is compatible with NPM 2.14.12. Looks like Trireme only supports 0.10.x currently:
https://github.com/apigee/trireme#what-version-of-nodejs-does-trireme-support |
@huntc See above -- I don't know enough about the project to be able to fix this (or know if it's fixable without other projects being involved) |
Nice investigations. Unfortunately Trireme is the lowest common denominator here. We can only support what that will support. |
Closing in favor of #10 |
Merging in the webjars upgrade locally. Will need to branch / tag for 1.1.2 (or 1.2? Minor or major upgrade?)
Following on from webjars/npm#4. Tested with sbt-js-engine using
sbt scripted
with no errors: