Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect type issues in conversation models methods #201

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix incorrect type issues in conversation models methods #201

merged 1 commit into from
Apr 24, 2024

Conversation

blenderskool
Copy link
Contributor

@blenderskool blenderskool commented Apr 24, 2024

Change Summary

Fixed following TypeScript related issues:

  • .conversations().models() was returning a union type that wasn't overloaded on the id param it accepts similar to other methods in the Typesense client.
  • .conversations().models().retrieve() was returning an incorrect type as { models: ConversationModelSchema[] } but from my tests it actually just returns an array of the model schemas.

PR Checklist

@jasonbosco
Copy link
Member

Thanks @blenderskool

Could you complete the CLA and complete the PR Checklist in the PR description?

@blenderskool
Copy link
Contributor Author

Done @jasonbosco

@jasonbosco jasonbosco merged commit 36dd89f into typesense:master Apr 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants