Skip to content

fix: expose total hits for pagy to use #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tharropoulos wants to merge 1 commit into from
Closed

fix: expose total hits for pagy to use #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/typesense-rails.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,6 +684,10 @@ def typesense_facets
@typesense_json["facet_counts"]
end

def total_hits
Copy link
Member

@jasonbosco jasonbosco Feb 20, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tharropoulos Every other method in the AdditionalMethods module has the prefix typesense_, so this method stands out as odd to me... Can we name this typesense_found and then may be create an alias method with an additional name for Pagy to use?

Copy link
Contributor Author

@tharropoulos tharropoulos Feb 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be closed, pagy doesn't rely on this method anymore, using the raw found value from the JSON response

@typesense_json["found"]
end

private

def typesense_init_raw_answer(json)
Expand Down