-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: discriminator-based resolution #1118
base: develop
Are you sure you want to change the base?
Conversation
Hi all, |
Many people are waiting for this fix, but authors still don't care about.
|
when? |
Hello. I need this fixes too. When will be released? |
Bump! Having issues with this |
Thanks for the PR kol-93 |
When will this update be released? |
@NoNameProvided I've not been active on the project for a while now. Could you take a look at this request or forward it to someone who could look into it? |
Bump, this is still an ongoing issue |
@NoNameProvided this is very needed feature |
@diffy0712 Can somebody review this PR? |
Description
Fixed:
type discriminator
property deleted from source object after plainToInstance/instanceToPlaincannot read property name of undefined
/cannot read property constructor of null
when trying to transform non-object (likenull
) to@Type()
with discriminatortype discriminator
property when usinginstanceToPlain
with@Exclude()
Added all functional tests for:
@Exclude()/@Expose()
@Exclude()/@Expose()
Checklist
Update index.md
)develop
)npm run prettier:check
passesnpm run lint:check
passesFixes
fixes #944
fixes #803
fixes #790
fixes #239