-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add authenticated user info to HTTP header #7
Open
m0t0k1ch1
wants to merge
6
commits into
typester:master
Choose a base branch
from
m0t0k1ch1:add-authenticated-user-info-to-http-header
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add authenticated user info to HTTP header #7
m0t0k1ch1
wants to merge
6
commits into
typester:master
from
m0t0k1ch1:add-authenticated-user-info-to-http-header
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@m0t0k1ch1 この機能、デフォルトではなにも送信しないように変更して取り込もうと思いますが、それで大丈夫でしょうか? |
それで大丈夫です!ありがとうございます |
あ、、放置してましたがなおします…! |
@m0t0k1ch1 はよ |
+1 |
@typester 修正しました。よろしくお願いします!:bow: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gate で認証をかけている管理画面などで、権限のある人しか実行できない操作を実装したいので、認証したユーザーの情報を HTTP ヘッダーに追加し、プロキシ先のアプリケーションなどで取得できるようにしました。
とりあえず、提案という意味合いも含め、直近で使用したい Google の認証の方にだけ実装しています。
いかがでしょう…?