CLI-1026: Catch malformed responses (#382)

typhonius · May 2, 2023 · 06fa9c8 · 06fa9c8
1 parent 8a019d6
commit 06fa9c8
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/src/Connector/Client.php b/src/Connector/Client.php
@@ -2,6 +2,7 @@
 
 namespace AcquiaCloudApi\Connector;
 
+use http\Exception\RuntimeException;
 use Psr\Http\Message\ResponseInterface;
 use GuzzleHttp\Exception\BadResponseException;
 use AcquiaCloudApi\Exception\ApiErrorException;
@@ -152,7 +153,15 @@ public function processResponse(ResponseInterface $response): mixed
     {
 
         $body_json = $response->getBody();
-        $body = json_decode($body_json);
+        $body = json_decode($body_json, null, 512, JSON_THROW_ON_ERROR);
+        if (is_null($body)) {
+            throw new RuntimeException(
+                'Response contained an empty body. Status '
+                . $response->getStatusCode()
+                . '. Request ID '
+                . $response->getHeaderLine('X-Request-Id')
+            );
+        }
 
         if (property_exists($body, '_embedded') && property_exists($body->_embedded, 'items')) {
             return $body->_embedded->items;