Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scrutinizer #454

Merged
merged 7 commits into from
May 28, 2024
Merged

Update scrutinizer #454

merged 7 commits into from
May 28, 2024

Conversation

danepowell
Copy link
Collaborator

@danepowell danepowell commented Apr 16, 2024

Builds are failing and I'm wondering if updating PHP / Composer will help.

@danepowell danepowell changed the title update scrutinizer Update scrutinizer Apr 16, 2024
@danepowell
Copy link
Collaborator Author

Updating PHP didn't help but I think logging into Scrutinizer so it could use my GitHub token to bypass rate limits may have done the trick.

@danepowell
Copy link
Collaborator Author

@typhonius can you make me an admin in Scrutinizer so I can figure out why it's failing? It's using an ancient version of PHPCodeSniffer for some reason.

Or else can we just disable Scrutinizer? I don't know what value it provides over what we could already do in GitHub Actions with PHPCS, PHPStan, etc

@typhonius
Copy link
Owner

danepowell

@typhonius can you make me an admin in Scrutinizer so I can figure out why it's failing? It's using an ancient version of PHPCodeSniffer for some reason.

Or else can we just disable Scrutinizer? I don't know what value it provides over what we could already do in GitHub Actions with PHPCS, PHPStan, etc

Have added you as an admin in scrutinizer. I don't think it's super necessary anymore to be honest. I think I added it in the first place because it was nice to have a badge on the readme that was green.

@danepowell
Copy link
Collaborator Author

No matter what I tried Scrutinizer kept trying to install an ancient version of PHPCS which broke in PHP 8.2

Finally in the UI I found an undocumented option on the "open source analysis tools config" tab to upgrade PHPCS and that fixed it.

I'll let it slide this time but if it keeps giving us grief I vote to disable scrutinizer.

@danepowell danepowell merged commit b9a4331 into typhonius:master May 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants