-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scrutinizer #454
Update scrutinizer #454
Conversation
Updating PHP didn't help but I think logging into Scrutinizer so it could use my GitHub token to bypass rate limits may have done the trick. |
@typhonius can you make me an admin in Scrutinizer so I can figure out why it's failing? It's using an ancient version of PHPCodeSniffer for some reason. Or else can we just disable Scrutinizer? I don't know what value it provides over what we could already do in GitHub Actions with PHPCS, PHPStan, etc |
Have added you as an admin in scrutinizer. I don't think it's super necessary anymore to be honest. I think I added it in the first place because it was nice to have a badge on the readme that was green. |
No matter what I tried Scrutinizer kept trying to install an ancient version of PHPCS which broke in PHP 8.2 Finally in the UI I found an undocumented option on the "open source analysis tools config" tab to upgrade PHPCS and that fixed it. I'll let it slide this time but if it keeps giving us grief I vote to disable scrutinizer. |
Builds are failing and I'm wondering if updating PHP / Composer will help.