Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update archive and passing tests #131

Closed
wants to merge 1 commit into from

Conversation

DerDrodt
Copy link
Contributor

Update archive files (since the CSL attribute for givenname-rule was wrong) and the passing tests.

@reknih Why is page_NoOption passing for you? It should not! Expanded is the default in Hayagriva if no PageRangeFormat is given and that should produce a different output.

@reknih
Copy link
Member

reknih commented Feb 20, 2024

It passed with the data and the citationberg version at 2e098f5 for me. Now it does not anymore!

@reknih
Copy link
Member

reknih commented Feb 20, 2024

Isn't the update of src/csl/archive.rs missing?

@reknih
Copy link
Member

reknih commented Apr 8, 2024

I updated the archive in eb13ecf and 22f4439 so I'm closing this for the time being.

@reknih reknih closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants