blkid: fix -Wunused-but-set-variable warning in blkid_read_cache()

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
tytso · Mar 28, 2024 · 33ee0c8 · 33ee0c8
1 parent 2e42f7b
commit 33ee0c8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lib/blkid/blkidP.h b/lib/blkid/blkidP.h
@@ -152,8 +152,10 @@ extern char *blkid_strndup(const char *s, const int length);
 #include <stdio.h>
 extern int	blkid_debug_mask;
 #define DBG(m,x)	if ((m) & blkid_debug_mask) x;
+#define INC_LINENO	lineno++
 #else
 #define DBG(m,x)
+#define INC_LINENO
 #endif
 
 #ifdef CONFIG_BLKID_DEBUG

diff --git a/lib/blkid/read.c b/lib/blkid/read.c
@@ -382,7 +382,10 @@ void blkid_read_cache(blkid_cache cache)
 {
 	FILE *file;
 	char buf[4096];
-	int fd, lineno = 0;
+	int fd;
+#ifdef CONFIG_BLKID_DEBUG
+	int lineno = 0;
+#endif
 	struct stat st;
 
 	if (!cache)
@@ -414,15 +417,15 @@ void blkid_read_cache(blkid_cache cache)
 		blkid_dev dev;
 		unsigned int end;
 
-		lineno++;
+		INC_LINENO;
 		if (buf[0] == 0)
 			continue;
 		end = strlen(buf) - 1;
 		/* Continue reading next line if it ends with a backslash */
 		while (buf[end] == '\\' && end < sizeof(buf) - 2 &&
 		       fgets(buf + end, sizeof(buf) - end, file)) {
 			end = strlen(buf) - 1;
-			lineno++;
+			INC_LINENO;
 		}
 
 		if (blkid_parse_line(cache, &dev, buf) < 0) {