Adds JSDoc support for EventManager #327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for electrodb-dev canceled.
|
package-lock.json
Outdated
There was a problem hiding this comment.
There was a version mismatch when installing.
| /** | ||
| * @type {Array<ElectroEventListener>} | ||
| * */ | ||
| #listeners; |
There was a problem hiding this comment.
Updated the class to use private properties
Comment on lines
+28
to
+29
| // no-op | ||
| return () => {}; |
There was a problem hiding this comment.
I could not get the filter to understand that undefined would have been removed even with type guards, so changed it to a no-op and removed the filter entirely.
Adds typechecking to Event Manager - Updates package-lock version mismatch - Fixes tests that broke after tsconfig change - Adds comment for ts error - Refactors types for simpler testing - Updates tests and types
niklaswallerstedt
force-pushed
the
feat/js-doc-support-event-manager
branch
from
58f4167 to
95a8acf
Compare
|
This is week is crazy for me, I hope to review this over the weekend 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables typechecking for JS and the Event Manager class.
Since the project is mostly written in javascript, I thought it would be suitable to start to add gradual types to the codebase. I've only started with the Event Manager class for you to get a feel of what it might look like and the DX around it.