pyo3 bindings for uap-python #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Jul 15, 2024
masklinn
added a commit
to masklinn/uap-python
that referenced
this pull request
Jul 15, 2024
Uses ua-parser/uap-rust#3 Fixes ua-parser#166
masklinn
force-pushed
the
pyo3-bindings
branch
24 times, most recently
from
98399a2
to
45efc61
Compare
masklinn
force-pushed
the
pyo3-bindings
branch
2 times, most recently
from
e97168a
to
014173a
Compare
masklinn
force-pushed
the
pyo3-bindings
branch
26 times, most recently
from
9f0762a
to
9bb89c1
Compare
Advantages ========== - Can do the entire loading in one shot in pure rust from a python iterable. - Work using rust semantics. - Really just works. - Only requires a pyi for type declarations (?). Drawbacks ========= - Likely slower than cffi for pypy, but unlikely to be slower than the slog of pure python. - Graal don't work in tox (oracle/graalpython#427).
masklinn
force-pushed
the
pyo3-bindings
branch
from
9bb89c1
to
9d7e95a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
add Sequoia (macos 15)moved everything to 13 insteadcheck why maturin-action creates a job for 12 / AMD64 but 14/ARM64...
turns out this is because the macOS 14 runners are ARM64 machines, while 12/13 are AMD64, so the jobs were switched over to avoid cross compilation (Use macOS M1 runner in generated GitHub Actions configuration PyO3/maturin#1952), it's not clear whether this is just an efficiency thing or if cross compilation caused issues
remove sdist? don't see what sense it makes...