-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile.deployment updates #3364
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_fs(:db) instead." warnings
…gainst external redirects
ConnorSheremeta
requested review from
jefferya,
lagoan,
murny and
pgwillia
as code owners
February 1, 2024 21:47
Generated by 🚫 Danger |
Was solved in #3320 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now builds, with help from the webpacker migration to esbuild resolving font-awesome issues (which this is currently based on, will rebase once that is merged), with the following unresolved warnings:
A bootstrap upgrade to at least 5.3.2 (currently on 4.6.2) is required to resolve this deprecation warning
(https://blog.getbootstrap.com/2023/09/14/bootstrap-5-3-2/). Ticket: #3366
Running
esbuild app/javascript/*.* --bundle --sourcemap --outdir=app/assets/builds --public-path=/assets
gives these warnings but they should be resolved upstream eventually:RUN curl -sL https://deb.nodesource.com/setup_16.x | bash -
Causes this script deprecation warning: (Ticket: #3367)
Which is slightly misleading. We will need to move off of node 16 to resolve this as it is no longer supported or possibly move away from it all together through import maps.