Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ module.exports = (source, settings, callback) => {

let isBinary = false;

// copy settings.args to prevent modifications
if (settings.args) settings.args = settings.args.slice(0);

if (!settings.args || settings.args.indexOf("-json") == -1) {
settings.args = settings.args || [];
settings.args.push("-json");
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "simple-exiftool",
"version": "1.1.0",
"version": "1.1.1",
"description": "Extracting metadata from media files with exiftool, including but not limited to mp4, mov, 3gp, jpg, png, gif, pdf.",
"main": "./lib/exif",
"scripts": {
Expand Down
13 changes: 13 additions & 0 deletions test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -173,4 +173,17 @@ describe("giving settings to simple-exiftool", () => {
});

});

it("should not modifiy given settings.args", (done) => {
var givenArgs=['-FileName'];
Exif(Path.join(__dirname, "files/lion.jpg"), {binary: exiftoolPath, args: givenArgs}, (error, metadata) => {

Expect(error).to.not.exist;
// giveArgs should not be modified
Expect(givenArgs).to.have.length(1);

done();
});

});
});