fixed issues with the setup script #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
engshahrad
commented
Oct 15, 2023
•
engshahrad
commented
- install Julia 1.9.3 if not installed (automatically handled for generic linux x86 and arm) (tested on linux x86 - ubuntu 22.04)
- check if directories exist before creating them
- check for pip and install if needed before using it
…talled and 2) check if directories exist before creating them
Minor modifications to the printed logs.
|
@engshahrad Looks all good to me. Just made minor modifications to the printed logs. I also think it is better just to keep |
|
Great, thanks for the quick review @GhazalSdn . Using python vs python3 was in the script before my changes. I just got rid of it so that only python3 is used. Will merge now. |
GhazalSdn
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.