Request merging Moodlecpd 4.1 LTS to Medicine branch #14
Conversation
Documentation in progress...
documenting in progresss...
uploaded custom icons
uploaded additional custom icons
uploaded custom icons
updated icons
updated more icons
updated custom icons
|
|
||
| #This is the latest version: And pending on Kate verification with her team. | ||
| #This is the latest version of plugin moodle33 as of 11Dec2023 |
There was a problem hiding this comment.
are those statement still valid?
| && curl -L https://moodle.org/plugins/download.php/11565/mod_certificate_moodle33_2016052300.zip -o /certificate.zip \ | ||
| && cp /certificate.zip /var/www/html/mod/ \ | ||
| && cd /var/www/html/mod \ | ||
| && unzip certificate.zip \ | ||
| && rm certificate.zip \ | ||
|
|
||
| && curl -L https://moodle.org/plugins/download.php/29419/mod_hvp_moodle42_2023061200.zip -o /hvp.zip \ | ||
| #Updated to newer hvp 10Dec2023 and 18Apr2024 |
There was a problem hiding this comment.
You don't need to add this kind of comment. The information can be reflect in the commit and commit message.
| ##FROM dangtue2020/moodlecore:419stg2-41ec0380b10f | ||
|
|
||
| ##Version 4.1.10 | ||
| ##FROM dangtue2020/moodlecore:4110-2d9b62e726d4 |
There was a problem hiding this comment.
This can be moved to commit message
| #&& cp /choicegroup.zip /var/www/html/mod/ \ | ||
| #&& cd /var/www/html/mod \ | ||
| #&& unzip choicegroup.zip \ | ||
| #&& rm choicegroup.zip \ |
There was a problem hiding this comment.
this can be deleted and move above comment to commit message.
| && curl -L https://moodle.org/plugins/download.php/16906/block_poll_moodle37_2018052500.zip -o /poll.zip \ | ||
| && cp /poll.zip /var/www/html/blocks/ \ | ||
| && cd /var/www/html/blocks \ | ||
| && unzip poll.zip \ | ||
| && rm poll.zip \ | ||
|
|
||
| && curl -L https://moodle.org/plugins/download.php/24644/report_customsql_moodle311_2021070700.zip -o /customsql.zip \ | ||
| #This is the latest version of plugin moodle31 as of 11Dec2023 |
| && curl -L https://moodle.org/plugins/download.php/14468/local_mass_enroll_moodle33_2015092402.zip -o /mass.zip \ | ||
| && rm flex.zip \ | ||
|
|
||
| # Kate requested to remove: |
There was a problem hiding this comment.
please remove this section and include the comment in the commit message
| # && rm facetoface.zip \ | ||
| # | ||
|
|
||
| #Updated as of 11Dec2023 |
| RUN sed -i.bak '/public function lang_menu/ i\ public function get_language() {return current_language();}\n' /var/www/html/lib/outputrenderers.php | ||
|
|
||
| RUN sleep 3 && echo "\$THEME->removedprimarynavitems = ['courses'];" >> /var/www/html/theme/maker/config.php | ||
| ##RUN sleep 3 && sed -i "\$a\\n\\n\$THEME->removedprimarynavitems = ['courses'];" /var/www/html/theme/maker/config.php |
There was a problem hiding this comment.
Yes, for line 223—this is a requirement from Kate to ensure that the course is not displayed in the students' menu.
| # add modified files for Language Icon | ||
| COPY themes/maker-header.mustache /var/www/html/theme/maker/templates/header.mustache | ||
| COPY themes/boost-language_menu.mustache /var/www/html/theme/boost/templates/language_menu.mustache | ||
| COPY themes/updated-icon-designs-4.1/mod/ /var/www/html/theme/maker/pix_plugins/mod |
There was a problem hiding this comment.
It would be very useful to add some comments about how we got those files. Did you write them or sent by Kate? So for future updates, we can trace them back to the source. Same for the fonts and favicon above.
There was a problem hiding this comment.
These mustache codes were modified to meet Kate's requirements based on the UX/UI specifications.
There was a problem hiding this comment.
Looks like this file is not being used. If this is a previous version of the theme and tracked in the git repo, we don't need keep it. If we need to rollback, we can revert this file. As long as you have each commit clearly titled and separated.
|
You're right about the comments—these were from the development cycles and need to be cleaned up and removed before the merge. I'll clean the comments in the medicine branch. 👍 |
Request to merge the old medicine branch with the latest CPD production Moodle 4.1.10 (Build: 20240422).