Skip to content

Add example vasp gpu container #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

Add example vasp gpu container #9

merged 1 commit into from
Apr 11, 2025

Conversation

aebruno
Copy link
Member

@aebruno aebruno commented Apr 3, 2025

No description provided.

@aebruno aebruno mentioned this pull request Apr 3, 2025
Closed
@aebruno aebruno requested review from dsajdak and ANekhai April 3, 2025 21:02
ANekhai
ANekhai approved these changes Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@ANekhai ANekhai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Dori can validate that VASP will build, I think the overall files are fine. I wouldn't go into much more depth with how to run VASP for now so I think the README is good. Looks clean and maintainable to me.

dsajdak
dsajdak requested changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@dsajdak dsajdak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestions after testing the build. Take them or leave them :)

dsajdak
dsajdak approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@dsajdak dsajdak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsajdak dsajdak merged commit 965d90b into main Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsajdak dsajdak dsajdak approved these changes

@ANekhai ANekhai ANekhai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aebruno @dsajdak @ANekhai