-
Notifications
You must be signed in to change notification settings - Fork 2
Send Email Notification on Chatbot Answer Change #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ribhavsharma
wants to merge
12
commits into
main
Choose a base branch
from
ribhav/chatbot-answer-changed-notif
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d942657
feat: add option to send email notificatoin when chatbot answer is ch…
ribhavsharma 7fbf392
add mail service to provider
ribhavsharma 31447de
remove unnecessary dependency from lms test
ribhavsharma eca8b32
reduce bottom margin of answer field
AdamFipke 11eeef3
addressing feedback
ribhavsharma 6110ee7
trying to fix test
ribhavsharma 0003ee1
fixing... test
ribhavsharma 9569e98
fix notifyUpdatedAnswer only callable by profs. Removed an . Added a …
AdamFipke 824bd79
Merge remote-tracking branch 'origin/main' into ribhav/chatbot-answer…
ribhavsharma cf46dad
addressing feedback
ribhavsharma c41c2ef
fix test
ribhavsharma 980bd5d
fixing flaky test + rm questionable workaround
ribhavsharma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ import { CacheModule } from '@nestjs/cache-manager'; | |
| import { ChatbotDataSourceService } from './chatbot-datasource/chatbot-datasource.service'; | ||
| import { ChatbotDataSourceModule } from './chatbot-datasource/chatbot-datasource.module'; | ||
| import { PostgresConnectionOptions } from 'typeorm/driver/postgres/PostgresConnectionOptions'; | ||
| import { MailService } from 'mail/mail.service'; | ||
|
|
||
| @Module({ | ||
| controllers: [ChatbotController], | ||
|
|
@@ -21,7 +22,12 @@ export class ChatbotModule { | |
| CacheModule.register(), | ||
| ChatbotDataSourceModule.forRoot(connectionOptions), | ||
| ], | ||
| providers: [ChatbotService, ChatbotApiService, ChatbotSettingsSubscriber], | ||
| providers: [ | ||
| ChatbotService, | ||
| ChatbotApiService, | ||
| ChatbotSettingsSubscriber, | ||
| MailService, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. huh interesting, i guess you didn't need to add |
||
| ], | ||
| }; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh neat I didn't know you could use the spread operator when deconstructing an object