Conversation
…Clear Profile Cache advanced setting, some misc tooltip and styling changes
AdamFipke
changed the title
bhunt02
left a comment
bhunt02
left a comment
There was a problem hiding this comment.
pretty good, some comments, re-request me when you've reviewed
| label="Coordinator Email" | ||
| name="coordinatorEmail" | ||
| tooltip="Email of the coordinator of the course" | ||
| tooltip="Email of the coordinator/instructor of the course" |
There was a problem hiding this comment.
i love these random flavor text changes in every PR
| documentText: values.content, | ||
| metadata: { | ||
| name: 'Manually Inserted Information', | ||
| name: values.name || 'Manually Inserted Information', |
There was a problem hiding this comment.
i'm anticipating merge conflicts with my vector store refactor... sigh... that's what i get for having a PR that is old
There was a problem hiding this comment.
it might be abusable though depending on your route
| label: 'Chatbot History', | ||
| children: <UserChatbotHistory />, | ||
| }, | ||
| { |
There was a problem hiding this comment.
i thought having it as a family of options might've been useful, the dropdown also prevented it from being shown by default (comparable to other advanced settings in similar webapps)
There was a problem hiding this comment.
I think it's about the same UX either way (plus it's a rare usecase), but I could change it back if you'd prefer. Also I'm not entirely sure I know what you mean by the dropdown preventing it from being shown by default?
There was a problem hiding this comment.
IIRC, the advanced options would only show when highlighted or selected. ants is weird tho and i cant remember exactly
There was a problem hiding this comment.
yeah I believe before it was a submenu, where you click Advanced -> submenu with [Access Tokens, Clear Cache] -> Click on item and taken to dedicated page for that item.
What I did here was just make one "Advanced" page with both Access Tokens and Clear Cache on the same page, which I guess is shown on the screenshots in the PR description. It's basically the same, maybe just a little more consistent with our profile settings pages but it's kinda subjective.
| } | ||
| } | ||
|
|
||
| @Delete('/clear_cache') |
There was a problem hiding this comment.
throttle/rate limit on this please...
There was a problem hiding this comment.
sure, i'll put like 5 calls allowed per 5 minutes should be good i think
2 participants
Description
I'm cannibalizing #259 and splitting it into multiple PRs. For context, back then I assumed I would've had that all merged before things got busy, so I made a bunch of misc changes in that PR that should've been its own thing. Here's some of them.
Small refactor of Advanced Settings and addition of a Clear Profile Cache button
Before it used a submenu. While I did like it, I kinda just wanted to have one unified "Advanced Settings" page since that's how other sites do it, but these changes/differences are also very small so it doesn't really matter that much.
Fix course preference table
Before
After
Add a new "name" field when manually creating a chunk
Previously, all manually inserted chunks were always "Manually Inserted Information" for their 'name' field, this just lets them customize it. You could always edit it after the fact
Type of change
yarn installHow Has This Been Tested?
Manually tested the changes.
Checklist:
console.logs, leftover unused logic, or anything else that was accidentally committed)