Skip to content

Show Hidden Anytime Questions Count + Update Copy/Text#482

Merged
kjassani merged 13 commits intomainfrom
karim/show-hidden-anytime-questions
Feb 25, 2026
Merged

Show Hidden Anytime Questions Count + Update Copy/Text#482
kjassani merged 13 commits intomainfrom
karim/show-hidden-anytime-questions

Conversation

@kjassani
Copy link
Collaborator

@kjassani kjassani commented Feb 23, 2026

Description

This PR implements the Anytime Questions UX/data requirements for hidden private questions and updates the chatbot-to-anytime CTA text/copy.

  • Shows +X additional private question(s) on the last page under the list.
  • Shows empty state: No questions have been posted here yet when no questions exist.
  • Shows empty state: No public or questions you created found when only hidden/non-visible questions exist.
  • Shows hidden count in that empty state as well.

Updated chatbot CTA text:

  • From: Unhappy with your answer? Convert to an Anytime Question
  • To: Discuss or verify this with your professor/TA: Convert to Anytime Question

Closes #468

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This requires a run of yarn install
  • This change requires an addition/change to the production .env variables. These changes are below:
  • This change requires developers to add new .env variables. The file and variables needed are below:
  • This change requires a database query to update old data on production. This query is below:

How Has This Been Tested?

  • Updated integration test to now read response.body.questions, and assert response.body.hiddenPrivateQuestionsCount where relevant.
  • Added three new integration tests for hidden-count behavior:
    1. Student sees no visible questions but hidden count is greater than zero

    2. Hidden count excludes TADeleted questions

    3. Hidden count excludes the requester’s own private questions

Manual Testing:

Click to expand manual testing screenshots

Empty State and Hidden Question:

Screenshot 2026-02-22 at 6 09 55 PM

studentTwo view when studentOne created 1 private question and 2 public questions:
Screenshot 2026-02-23 at 12 54 34 PM

studentOne view when they themselves created 1 private question and 2 public questions:
Screenshot 2026-02-23 at 12 54 52 PM

Checklist:

  • I have performed a code review of my own code (under the "Files Changed" tab on github) to ensure nothing is committed that shouldn't be (e.g. leftover console.logs, leftover unused logic, or anything else that was accidentally committed)
  • I have commented my code where needed
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing tests pass locally with my changes
  • Any work that this PR is dependent on has been merged into the main branch
  • Any UI changes have been checked to work on desktop, tablet, and mobile

@kjassani kjassani self-assigned this Feb 23, 2026
…uce cognitive load as much as possible. Also added a 'Continue Navigation' popconfirm since I imagine people can accidentally click on it easily
…estions', and added a tooltip explaining it. Also converted the condition variables to be inside the JSX since it's very slightly easier to maintain when everything's together
Copy link
Collaborator

@AdamFipke AdamFipke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good! I just adjusted a few small things as I found them, it was easier for me to just fix the things directly rather than make comments for them since they're so small.

Should be good to merge

@kjassani
Copy link
Collaborator Author

changes look good! I just adjusted a few small things as I found them, it was easier for me to just fix the things directly rather than make comments for them since they're so small.

Should be good to merge

Perfect, thanks for adding those small things!

@kjassani kjassani merged commit 719e60c into main Feb 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show Number of hidden Anytime questions and change "Unhappy with your answer" text

2 participants