Replace use of text/template
with string manipulations
#425
+60
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424.
This PR replaces using a template to generate the graph in dot format with directly writing strings in the writer.
In particular it avoids disabling dead code elimination.
I tried to keep the same whitespaces (tab, newlines) as in the template to avoid modifying the test cases, and increase confidence that the change is equivalent.
I'd be very happy to remove the extra tab and newlines as they just make the code less readable.
The proposed implementation uses
fmt.Fprintf
to simplify, but it can be optimized by just usingw.Write
directly instead, avoiding some parsing and allocations. I considered that it was not a hot path so making the code simpler was worth it.