fix(dev-tools): drop deprecated node option #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8868428908Details
💛 - Coveralls |
ibgreen
approved these changes
Apr 28, 2024
| import {getValidPath, ocularRoot} from '../utils/utils.js'; | ||
| export {getFormat, transformSource, load}; | ||
|
|
||
| type ResolveHook = ( |
There was a problem hiding this comment.
Nit: Add TSDoc on the type (and fields if possible). Specify if this is this an ocular type or are we compensating for esbuild 's lack of types, if so which version of esbuild was this written for?
There was a problem hiding this comment.
This is Node.js API. I'll add a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--loader, use--import