Set debug=False by default #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the app to run with DEBUG=False unless the environment variable for FLASK_DEBUG has been explicitly set. [Flask's docs](http://flask.pocoo.org/docs/0.10/quickstart/#debug-mode) include a note about how this should never be run on production with debug=True. [Patreon](http://labs.detectify.com/post/130332638391/how-patreon-got-hacked-publicly-exposed-werkzeug) was supposedly just hacked because one of their test servers had debug=True enabled so I think it makes sense to keep it disabled by default in the interest of security.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the app to run with DEBUG=False unless the environment variable for FLASK_DEBUG has been explicitly set. Flask's docs include a note about how this should never be run on production with debug=True because it enables remote code execution. Patreon was supposedly just hacked because one of their test servers had debug=True enabled so I think it makes sense to keep it disabled by default in the interest of security.