Make torch optional. Update DragonNet w/ latest TF APIs #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeongyoonlee
requested review from
paullo0106,
ras44,
huigangchen,
ppstacy,
t-tte,
vincewu51,
alexander-pv and
zhenyuz0500
paullo0106
reviewed
Sep 14, 2024
| y, X, w, tau, b, e = simulate_nuisance_and_easy_treatment(n=1000) | ||
|
|
||
| dragon = DragonNet(neurons_per_layer=200, targeted_reg=True, verbose=False) | ||
| dragon_ite = dragon.fit_predict(X, w, y, return_components=False) | ||
| dragon_ate = dragon_ite.mean() | ||
| dragon.save("smaug") | ||
|
|
||
| model_file = tmp_path / "smaug.h5" |
There was a problem hiding this comment.
@jeongyoonlee did you mean f"{tmp_path}/smaug.h5" ? I'm not super familiar with the code here
There was a problem hiding this comment.
tmp_path is a Pathlib object and this is a valid syntax. :)
There was a problem hiding this comment.
i see, makes sense then!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes #789 by making the torch dependency optional.
It also fixes the
DragonNettest error with the latest Tensorflow APIs.Types of changes
What types of changes does your code introduce to CausalML?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
N/A