Skip to content

Test cellsToLinkedMultiPolygon for children of pentagon #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Test cellsToLinkedMultiPolygon for children of pentagon #916

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7a37a85
bug on cellsToLinkedMultiPolygon for children of pentagon
ajfriend Sep 26, 2024
6eca1ab
bah
ajfriend Sep 26, 2024
dc7b15a
we expect 1 loop, no holes
ajfriend Sep 27, 2024
68b8d84
test (incorrectly) for 2 loops
ajfriend Sep 27, 2024
87b7014
back to expecting (correctly) 1 loop
ajfriend Sep 27, 2024
b7978f3
try to test on both x86_64 and Apple Silicon
ajfriend Sep 27, 2024
c30fb5c
for now, ensure all macos jobs run, even if one fails
ajfriend Sep 27, 2024
e9a50e7
shorter name so we can see the OS version
ajfriend Sep 27, 2024
8aed513
Update src/apps/testapps/testCellsToLinkedMultiPolygon.c
ajfriend Sep 27, 2024
61fc849
Update src/apps/testapps/testCellsToLinkedMultiPolygon.c
ajfriend Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/test-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,13 @@ on:

jobs:
tests:
name: Test Compile ${{ matrix.build_type }}
runs-on: macos-latest
name: ${{ matrix.build_type }} on ${{ matrix.os }}
runs-on: ${{ matrix.os }}

strategy:
fail-fast: false
matrix:
os: [macos-12, macos-13, macos-latest]
build_type: ["Debug", "Release"]

steps:
Expand Down
18 changes: 18 additions & 0 deletions src/apps/testapps/testCellsToLinkedMultiPolygon.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,24 @@ SUITE(cellsToLinkedMultiPolygon) {
H3_EXPORT(destroyLinkedMultiPolygon)(&polygon);
}

TEST(pentagonChldren) {
// children of pentagon 0x80ebfffffffffff
H3Index kids[] = {0x81ea3ffffffffff, 0x81eabffffffffff,
0x81eafffffffffff, 0x81eb3ffffffffff,
0x81eb7ffffffffff, 0x81ebbffffffffff};
int numCells = ARRAY_SIZE(kids);
Comment on lines +76 to +80
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this happen for any set of res 1 children of a res 0 pentagon?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the notebook here: https://gist.github.com/ajfriend/5594157463b88eb8d4cae35705657d8d

At res 1, it only happens for 80ebfffffffffff. (but it also happens for res 2... let me get a list)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At res 2, exactly two pentagons of the 12 do not work: 8009fffffffffff and 80c3fffffffffff


LinkedGeoPolygon polygon;
t_assertSuccess(
H3_EXPORT(cellsToLinkedMultiPolygon)(kids, numCells, &polygon));

// Since these are the children of a cell, we exepect a single loop with
// no holes.
t_assert(countLinkedLoops(&polygon) == 1, "1 loop added to polygon");

H3_EXPORT(destroyLinkedMultiPolygon)(&polygon);
}

// TODO: This test asserts incorrect behavior - we should be creating
// multiple polygons, each with their own single loop. Update when the
// algorithm is corrected.
Expand Down
Loading