Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused app_name string resource #104

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove unused app_name string resource #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7390cb6
remove unused string
davissuber Sep 20, 2024
ee0fce2
fix github action yaml file
davissuber Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:
jobs:
build:
name: JDK ${{ matrix.java_version }}
runs-on: macOS-latest
runs-on: macos-13
Copy link
Contributor Author

@davissuber davissuber Sep 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit tricky to balance between the 3 versions:

  1. emulator api level (currently at 21, bumping to newer ones means we need to move the abi away from x86)
  2. emulator abi (due to this being on macos, the only real long term option is arm64-v8a)
  3. osx version (VMs on Apple silicon is allegedly having some problem with emulators, which may get resolved in osx15 with M3 chips; I am guessing it will be some time before we have M3 running osx15 on github actions

I am not sure if it make sense to consider moving to ubuntu (like our other github actions) and fight the emulator war there.

strategy:
matrix:
java_version: [11]
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:
abi: x86
- name: Full check
run: ./gradlew check --stacktrace
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2 is deprecated and without bumping it - this job automatically fails.

with:
name: Sample App
path: sample/build/outputs
3 changes: 0 additions & 3 deletions protosimplestore/src/main/res/values/strings.xml
View file
Open in desktop

This file was deleted.

Loading