Limit code_challenge to shouldExchangeAuthCode only#305
Merged
mohssenfathi merged 1 commit intouber:2.xfrom Jul 1, 2024
Merged
Limit code_challenge to shouldExchangeAuthCode only#305mohssenfathi merged 1 commit intouber:2.xfrom
mohssenfathi merged 1 commit intouber:2.xfrom
Conversation
renan-ssoares
approved these changes
Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where we send code_challenge in the authorize request when we shouldn't be. We should only be sending a codeChallenge to the authorize endpoint in cases where we want to exchange auth code for auth token on device.
Changes
codeChallengeproperty optionalcode_challenge_methodifcodeChallengeis non-nilshouldExchangeAuthCodeis trueTesting
code_challengeandcode_challenge_methodare not being sent for both inApp and native login destinations