Allow drag n drop & fix a few issues with file sharing #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also “bump” language level to allow `..<`
We are using Glide to load thumbnails for all shares. If the request fails, Glide will re-attempt to fetch the image when the activity is resumed, e.g. when you switch to another app and back. This fixes the issue by cancelling the request on failure.
When inserting images & other media into the chat input, we add spaces around it to make sure the text doesn't touch the resulting URL. But if the user edits the text after, the text might touch the image again. This sometimes is hard to see, especially if the thumbnail and the text are on separate lines. To overcome this, also insert spaces around the URL when textifying.
In buffer fragments, we are saving input for parallel fragments (i.e. bubbles) on pause and restoring it on resume. On some systems, particularly on API 27, it's possible that, when dragging from another app, the target activity isn't actually resumed, hence this input change may fail to be recorded. To prevent this, explicitly record the change after loading the thumbnails. This includes a long-postponed conversion of thumbnail logic to coroutines. This facilitates waiting until the thumbnails are actually loaded and applied to the string.
|
Please review, paying attention to the last commit. Coroutines can be deceiving |
mhoran
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
For drag n drop, the entire buffer fragment acts like a drop target.
I'm not sure whether or not we need drag-n-drop indicators, like the ones you see in Gmail. One one hand, we normally only show a single buffer. On the other, it might be somewhat useful to indicate that the buffer list or the title bar are not targets for dropping files. I decided to not do any indicators because I am lazy and who even drags and drops files on Android anyway.