Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: used ubiquity-os-logger for logging #19

Merged
merged 9 commits into from
Oct 25, 2024
Merged

feat: used ubiquity-os-logger for logging #19

merged 9 commits into from
Oct 25, 2024

Conversation

ariesgun
Copy link
Contributor

Resolves #4

@ariesgun ariesgun marked this pull request as draft October 18, 2024 14:37
@ariesgun ariesgun marked this pull request as ready for review October 18, 2024 14:37
gentlementlegen
gentlementlegen requested changes Oct 21, 2024
View reviewed changes
src/handlers/query-wallet.ts Outdated Show resolved Hide resolved
src/types/context.ts Outdated Show resolved Hide resolved
@gentlementlegen
Copy link
Member

@ariesgun I am okay with the changes, however the Jest testing suite is failing, please fix it first.

@github-actions GitHub Actions
Copy link
Contributor

Unlisted dependencies (1)

Filename unlisted
tests/main.test.ts @ethersproject/providers

gentlementlegen
gentlementlegen reviewed Oct 24, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
gentlementlegen
gentlementlegen reviewed Oct 24, 2024
View reviewed changes
tests/main.test.ts Outdated Show resolved Hide resolved
ariesgun and others added 2 commits October 24, 2024 08:19
@ariesgun @gentlementlegen
fix: update package.json
f2dc71a 
Co-authored-by: Mentlegen <9807008+gentlementlegen@users.noreply.github.com>
@ariesgun
fix: removed comma in the package.json
de783d3
@0x4007 0x4007 removed their request for review October 24, 2024 08:39
@ariesgun
Copy link
Contributor Author

I reverted the changes and the tests also pass

@ariesgun I am okay with the changes, however the Jest testing suite is failing, please fix it first.

I reverted the changes and the tests also pass

@gentlementlegen
Copy link
Member

QA: Meniole#5 (comment)
Please provide your own QA as well next time.

@gentlementlegen gentlementlegen merged commit 142b6e6 into ubiquity-os-marketplace:development Oct 25, 2024
2 checks passed
@ubiquity-os-beta ubiquity-os-beta bot mentioned this pull request Oct 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gentlementlegen gentlementlegen gentlementlegen approved these changes

@0x4007 0x4007 Awaiting requested review from 0x4007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change logs to use ubiquity-dao/ubiquibot-logger
3 participants
@ariesgun @gentlementlegen @0x4007