Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: schema validation #21

Conversation

gentlementlegen
Copy link
Member

@gentlementlegen gentlementlegen commented Sep 21, 2024

Copy link
Contributor

github-actions bot commented Sep 21, 2024

Unused files (1)

src/update-configuration.ts

@gentlementlegen gentlementlegen changed the title Feat/schema validation feat: schema validation Sep 24, 2024
@gentlementlegen gentlementlegen marked this pull request as ready for review October 2, 2024 05:44
@gentlementlegen gentlementlegen requested a review from 0x4007 October 2, 2024 05:45
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think handling the undefined elements before placing into the array is better practice, although I don't know the full context of how that array is being used.

manifest.json Show resolved Hide resolved
src/handlers/summary.ts Show resolved Hide resolved
src/handlers/summary.ts Show resolved Hide resolved
src/helpers/validator.ts Outdated Show resolved Hide resolved
@0x4007 0x4007 merged commit 425758a into ubiquity-os-marketplace:development Oct 3, 2024
2 checks passed
@gentlementlegen gentlementlegen deleted the feat/schema-validation branch October 3, 2024 11:03
@gentlementlegen
Copy link
Member Author

@0x4007 We will need all the plugins to be updated so this can work properly, updating the PRs now.

@0x4007
Copy link
Member

0x4007 commented Oct 3, 2024

I see potential in this being a general purpose tool to update across all plugins etc

https://github.com/0x4007/sync-configs

It's still early on but it's pretty reliable at updating configs from cli now. Still want to figure out git authentication from GitHub actions to be able to clone and edit private repositories.

@gentlementlegen
Copy link
Member Author

@0x4007 Yes it would definitely be handy. The problem is that the generation action is differing from one repo to another, due to certain repo being modules and others commonjs, so the imports do not work the same.

@0x4007
Copy link
Member

0x4007 commented Oct 4, 2024

It's fine but to simplify I need to specify the target file for each repo to change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration validation and annotations on errors
2 participants