-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: schema validation #21
feat: schema validation #21
Conversation
Unused files (1)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think handling the undefined elements before placing into the array is better practice, although I don't know the full context of how that array is being used.
@0x4007 We will need all the plugins to be updated so this can work properly, updating the PRs now. |
I see potential in this being a general purpose tool to update across all plugins etc https://github.com/0x4007/sync-configs It's still early on but it's pretty reliable at updating configs from cli now. Still want to figure out git authentication from GitHub actions to be able to clone and edit private repositories. |
@0x4007 Yes it would definitely be handy. The problem is that the generation action is differing from one repo to another, due to certain repo being modules and others commonjs, so the imports do not work the same. |
It's fine but to simplify I need to specify the target file for each repo to change |
Resolves ubiquity-os/ubiquity-os-kernel#80