Merge pull request #27 from gentlementlegen/fix/issue-closed-skip

fix: issue closed as non-planned is now skipped

src/index.ts

@@ -1,23 +1,7 @@
 import * as core from "@actions/core";
-import { IssueActivity } from "./issue-activity";
-import program from "./parser/command-line";
-import { Processor } from "./parser/processor";
-import { parseGitHubUrl } from "./start";
+import { run } from "./run";
 
-async function main() {
-  if (program.eventName === "issues.closed") {
-    const issue = parseGitHubUrl(program.eventPayload.issue.html_url);
-    const activity = new IssueActivity(issue);
-    await activity.init();
-    const processor = new Processor();
-    await processor.run(activity);
-    return processor.dump();
-  } else {
-    console.warn(`${program.eventName} is not supported, skipping.`);
-  }
-}
-
-main()
+run()
   .then((result) => {
     core?.setOutput("result", result);
   })

src/run.ts

@@ -0,0 +1,31 @@
+import { IssueActivity } from "./issue-activity";
+import program from "./parser/command-line";
+import { Processor } from "./parser/processor";
+import { parseGitHubUrl } from "./start";
+import { getOctokitInstance } from "./get-authentication-token.ts";
+
+export async function run() {
+  const { eventPayload, eventName } = program;
+  if (eventName === "issues.closed") {
+    if (eventPayload.issue.state_reason !== "completed") {
+      const result = "# Issue was not closed as completed. Skipping.";
+      await getOctokitInstance().issues.createComment({
+        body: `\`\`\`text\n${result}\n\`\`\``,
+        repo: eventPayload.repository.name,
+        owner: eventPayload.repository.owner.login,
+        issue_number: eventPayload.issue.number,
+      });
+      return result;
+    }
+    const issue = parseGitHubUrl(eventPayload.issue.html_url);
+    const activity = new IssueActivity(issue);
+    await activity.init();
+    const processor = new Processor();
+    await processor.run(activity);
+    return processor.dump();
+  } else {
+    const result = `${eventName} is not supported, skipping.`;
+    console.warn(result);
+    return result;
+  }
+}

tests/__mocks__/handlers.ts

@@ -114,4 +114,7 @@ export const handlers = [
     const createdPermit = db.permits.create(data);
     return HttpResponse.json(createdPermit);
   }),
+  http.post("https://api.github.com/repos/:owner/:repo/issues/:id/comments", () => {
+    return HttpResponse.json({});
+  }),
 ];

tests/action.test.ts

@@ -0,0 +1,41 @@
+/* eslint @typescript-eslint/no-var-requires: 0 */
+import "../src/parser/command-line";
+import { run } from "../src/run";
+import { server } from "./__mocks__/node.ts";
+
+beforeAll(() => server.listen());
+afterEach(() => server.resetHandlers());
+afterAll(() => server.close());
+
+jest.mock("../src/parser/command-line", () => {
+  const cfg = require("./__mocks__/results/valid-configuration.json");
+  const dotenv = require("dotenv");
+  dotenv.config();
+  return {
+    stateId: 1,
+    eventName: "issues.closed",
+    authToken: process.env.GITHUB_TOKEN,
+    ref: "",
+    eventPayload: {
+      issue: {
+        html_url: "https://github.com/ubiquibot/comment-incentives/issues/22",
+        number: 1,
+        state_reason: "not_planned",
+      },
+      repository: {
+        name: "conversation-rewards",
+        owner: {
+          login: "ubiquibot",
+        },
+      },
+    },
+    settings: JSON.stringify(cfg),
+  };
+});
+
+describe("Action tests", () => {
+  it("Should skip when the issue is closed without the completed status", async () => {
+    const result = await run();
+    expect(result).toEqual("# Issue was not closed as completed. Skipping.");
+  });
+});

tests/process.issue.test.ts

@@ -41,7 +41,17 @@ jest.mock("../src/parser/command-line", () => {
     authToken: process.env.GITHUB_TOKEN,
     ref: "",
     eventPayload: {
-      issue: { html_url: "https://github.com/ubiquibot/comment-incentives/issues/22" },
+      issue: {
+        html_url: "https://github.com/ubiquibot/comment-incentives/issues/22",
+        number: 1,
+        state_reason: "completed",
+      },
+      repository: {
+        name: "conversation-rewards",
+        owner: {
+          login: "ubiquibot",
+        },
+      },
     },
     settings: JSON.stringify(cfg),
   };