Skip to content

ci: run knip-reporter on failure #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Jun 19, 2024

Check this CI run which failed with error Unable to download artifact(s): Artifact not found for name: knip-results .

It happened because knip workflow uploads results only on failure while knip-reporter workflow tries to download knip results every time. So when there are no knip errors the knip-reporter workflow tries to download an artifact that doesn't exist.

This PR runs knip-reporter workflow only if knip workflow failed. This way the knip results artifact is always present and the Unable to download artifact(s): Artifact not found for name: knip-results error is gone (along with github notifications).

QA (no knip errors):

QA (with knip errors):

@rndquu rndquu marked this pull request as ready for review June 19, 2024 22:02
@gitcoindev
Copy link
Contributor

Makes sense! This case will indeed be fixed by this change.

@gitcoindev gitcoindev merged commit e064951 into ubiquity-os-marketplace:development Jun 20, 2024
2 checks passed
@rndquu rndquu deleted the ci/run-knip-on-fail branch June 20, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants