ci: run knip-reporter on failure #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check this CI run which failed with error
Unable to download artifact(s): Artifact not found for name: knip-results
.It happened because knip workflow uploads results only on failure while knip-reporter workflow tries to download knip results every time. So when there are no knip errors the knip-reporter workflow tries to download an artifact that doesn't exist.
This PR runs knip-reporter workflow only if knip workflow failed. This way the knip results artifact is always present and the
Unable to download artifact(s): Artifact not found for name: knip-results
error is gone (along with github notifications).QA (no knip errors):
QA (with knip errors):