Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

Infer type implicitly #18

Closed
wants to merge 1 commit into from
Closed

Infer type implicitly #18

wants to merge 1 commit into from

Conversation

whilefoo
Copy link

Resolves ubiquity-os/ubiquity-os-kernel#45

Why do we have config duplicated here and in the kernel repo? I'm not even sure why the kernel configuration needs to be in a separate package because it won't be used by plugins?

There appears to be a env schema in this repo that looks like its from the old bot, @gentlementlegen do you know if it's even used anywhere?

@whilefoo whilefoo requested a review from gentlementlegen May 28, 2024 15:43
Copy link
Contributor

Lines Statements Branches Functions
Coverage: NaN%
Unknown% (0/0) Unknown% (0/0) Unknown% (0/0)

JUnit

Tests Skipped Failures Errors Time
0 0 💤 0 ❌ 0 🔥 4.46s ⏱️

@gentlementlegen
Copy link
Member

gentlementlegen commented May 29, 2024

@whilefoo used to be this way since configuration was shared in a few repositories and was not sent as we do now through the kernel, leading to a lot of duplicated code, which this package solved. I guess now it would become obsolete with the new architecture.

But I am a bit confused about why you are making these changes to the old bot? The new kernel already has the capability to read urls or Actions, when I made the issue you mentioned I thought simply about removing the type and updating the related configuration (can't add multiple reviewers to that one somehow).


export type Plugin = GithubPlugin | HttpsPlugin;

function githubPluginType() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function githubPluginType() {
function githubPluginType(): Plugin {

It might be safer to declare the type here instead of typecasting it below

@whilefoo
Copy link
Author

But I am a bit confused about why you are making these changes to the old bot?

I thought this repo is still used, we should archive it then

@gentlementlegen
Copy link
Member

@whilefoo Repo is still used for the production but is in maintenance mode right now I guess, if you can confirm @0x4007

@0x4007
Copy link
Member

0x4007 commented Jun 3, 2024

@whilefoo Repo is still used for the production but is in maintenance mode right now I guess, if you can confirm @0x4007

The work in this repo should not be prioritized, in favor of shipping v2 of the bot. However, for some critical fixes, yes we can push and deploy here.

@whilefoo whilefoo closed this Jun 3, 2024
@0x4007
Copy link
Member

0x4007 commented Jun 4, 2024

@whilefoo @gentlementlegen I just realized this is for the npm module, which indeed is being used in the new bot lol sorry about that.

This repo is not github.com/ubiquity/ubiquibot

I might rebrand the project to https://github.com/ubiquity-os and then have a project under there called kernel or something. Perhaps we can leave behind the ubiquibot terminology, and relegate it to refer to v1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove type from configuration in plugins
3 participants