-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
@whilefoo used to be this way since configuration was shared in a few repositories and was not sent as we do now through the kernel, leading to a lot of duplicated code, which this package solved. I guess now it would become obsolete with the new architecture. But I am a bit confused about why you are making these changes to the old bot? The new kernel already has the capability to read urls or Actions, when I made the issue you mentioned I thought simply about removing the type and updating the related configuration (can't add multiple reviewers to that one somehow). |
|
||
export type Plugin = GithubPlugin | HttpsPlugin; | ||
|
||
function githubPluginType() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function githubPluginType() { | |
function githubPluginType(): Plugin { |
It might be safer to declare the type here instead of typecasting it below
I thought this repo is still used, we should archive it then |
@whilefoo @gentlementlegen I just realized this is for the npm module, which indeed is being used in the new bot lol sorry about that. This repo is not I might rebrand the project to https://github.com/ubiquity-os and then have a project under there called kernel or something. Perhaps we can leave behind the |
Resolves ubiquity-os/ubiquity-os-kernel#45
Why do we have config duplicated here and in the kernel repo? I'm not even sure why the kernel configuration needs to be in a separate package because it won't be used by plugins?
There appears to be a env schema in this repo that looks like its from the old bot, @gentlementlegen do you know if it's even used anywhere?