Merge branch 'development' into feat/npm-package

.cspell.json

@@ -29,6 +29,7 @@
     "libsodium",
     "Libsodium",
     "ciphertext",
-    "tweetnacl"
+    "tweetnacl",
+    "typeguards"
   ]
 }

.github/workflows/compute.yml

@@ -30,7 +30,7 @@ jobs:
           node-version: "20.10.0"
 
       - name: Install dependencies
-        run: yarn i --immutable --immutable-cache --check-cache
+        run: yarn install --immutable --immutable-cache --check-cache
 
       - name: Generate Permit
         run: npx tsx ./src/index.ts

.github/workflows/knip-reporter.yml

@@ -0,0 +1,49 @@
+name: Knip-reporter
+
+on:
+  workflow_run:
+    workflows: ["Knip"]
+    types:
+      - completed
+
+jobs:
+  knip-reporter:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20.10.0
+
+      - name: Install toolchain
+        run: yarn install
+
+      - uses: actions/download-artifact@v4
+        with:
+          name: knip-results
+          run-id: ${{ github.event.workflow_run.id }}
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Read pr number
+        id: pr-number
+        uses: juliangruber/read-file-action@v1
+        with:
+          path: ./pr-number.txt
+          trim: true
+
+      - name: Report knip results to pull request
+        if: ${{ github.event.workflow_run.conclusion != 'success' }}
+        uses: gitcoindev/knip-reporter@main
+        with:
+          verbose: true
+          comment_id: ${{ github.workflow }}-reporter
+          command_script_name: knip-ci
+          annotations: true
+          ignore_results: false
+          json_input: true
+          json_input_file_name: knip-results.json
+          pull_request_number: ${{ steps.pr-number.outputs.content }}
+          token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/knip.yml

@@ -3,8 +3,6 @@ name: Knip
 on:
   pull_request:
 
-permissions: write-all
-
 jobs:
   run-knip:
     runs-on: ubuntu-latest
@@ -20,11 +18,17 @@ jobs:
       - name: Install toolchain
         run: yarn install
 
-      - name: Report knip results to pull request
-        uses: Codex-/knip-reporter@v2
+      - name: Store PR number
+        run: echo ${{ github.event.number }} > pr-number.txt
+
+      - name: Run Knip
+        run: yarn knip || yarn -s knip --reporter json > knip-results.json
+
+      - name: Upload knip result
+        if: failure()
+        uses: actions/upload-artifact@v4
         with:
-          verbose: true
-          comment_id: ${{ github.workflow }}-reporter
-          command_script_name: knip-ci
-          annotations: true
-          ignore_results: false
+          name: knip-results
+          path: |
+            knip-results.json
+            pr-number.txt

knip.ts

@@ -3,9 +3,13 @@ import type { KnipConfig } from "knip";
 const config: KnipConfig = {
   entry: ["build/index.ts"],
   project: ["src/**/*.ts"],
-  ignore: ["src/types/config.ts"],
+  ignore: [],
   ignoreExportsUsedInFile: true,
-  ignoreDependencies: [],
+  ignoreDependencies: ["ts-node"],
+  jest: {
+    config: ["jest.config.ts"],
+    entry: ["tests/*.ts"],
+  },
 };
 
 export default config;

package.json

@@ -2,6 +2,7 @@
   "name": "@ubiquibot/permit-generation",
   "version": "1.0.0",
   "description": "ECR20 / ECR721 permit generation for automated payments.",
+  "main": "src/index.ts",
   "author": "Ubiquity DAO",
   "license": "MIT",
   "engines": {
@@ -30,20 +31,14 @@
     "@actions/github": "^6.0.0",
     "@octokit/rest": "^20.0.2",
     "@octokit/webhooks": "^13.1.0",
-    "@octokit/webhooks-types": "^7.3.1",
     "@sinclair/typebox": "^0.32.5",
     "@supabase/supabase-js": "^2.39.7",
     "@uniswap/permit2-sdk": "^1.2.0",
-    "blake2b": "^2.1.4",
-    "decimal.js": "^10.4.3",
     "dotenv": "^16.4.4",
     "ethers": "6.11.1",
-    "libsodium-wrappers": "^0.7.13",
-    "tweetnacl": "^1.0.3",
-    "tweetnacl-util": "^0.15.1"
+    "libsodium-wrappers": "^0.7.13"
   },
   "devDependencies": {
-    "@cloudflare/workers-types": "^4.20240117.0",
     "@commitlint/cli": "^18.6.1",
     "@commitlint/config-conventional": "^18.6.2",
     "@cspell/dict-node": "^4.0.3",
@@ -61,10 +56,7 @@
     "@typescript-eslint/eslint-plugin": "^7.0.1",
     "@typescript-eslint/parser": "^7.0.1",
     "cspell": "^8.4.0",
-    "esbuild": "^0.20.1",
     "eslint": "^8.56.0",
-    "eslint-config-prettier": "^9.1.0",
-    "eslint-plugin-prettier": "^5.1.3",
     "eslint-plugin-sonarjs": "^0.24.0",
     "husky": "^9.0.11",
     "jest": "29.7.0",
@@ -79,8 +71,7 @@
     "ts-jest": "29.1.2",
     "ts-node": "10.9.2",
     "tsx": "^4.7.1",
-    "typescript": "^5.3.3",
-    "wrangler": "^3.23.0"
+    "typescript": "^5.3.3"
   },
   "lint-staged": {
     "*.ts": [

src/adapters/supabase/types/database.ts

@@ -79,6 +79,7 @@ export type Database = {
 
 type PublicSchema = Database[Extract<keyof Database, "public">];
 
+/** @public */
 export type Tables<
   PublicTableNameOrOptions extends keyof (PublicSchema["Tables"] & PublicSchema["Views"]) | { schema: keyof Database },
   TableName extends PublicTableNameOrOptions extends { schema: keyof Database }
@@ -98,6 +99,7 @@ export type Tables<
       : never
     : never;
 
+/** @public */
 export type TablesInsert<
   PublicTableNameOrOptions extends keyof PublicSchema["Tables"] | { schema: keyof Database },
   TableName extends PublicTableNameOrOptions extends { schema: keyof Database } ? keyof Database[PublicTableNameOrOptions["schema"]]["Tables"] : never = never,
@@ -115,6 +117,7 @@ export type TablesInsert<
       : never
     : never;
 
+/** @public */
 export type TablesUpdate<
   PublicTableNameOrOptions extends keyof PublicSchema["Tables"] | { schema: keyof Database },
   TableName extends PublicTableNameOrOptions extends { schema: keyof Database } ? keyof Database[PublicTableNameOrOptions["schema"]]["Tables"] : never = never,
@@ -132,6 +135,7 @@ export type TablesUpdate<
       : never
     : never;
 
+/** @public */
 export type Enums<
   PublicEnumNameOrOptions extends keyof PublicSchema["Enums"] | { schema: keyof Database },
   EnumName extends PublicEnumNameOrOptions extends { schema: keyof Database } ? keyof Database[PublicEnumNameOrOptions["schema"]]["Enums"] : never = never,

src/handlers/generate-erc721-permit.ts

@@ -97,10 +97,10 @@ export async function generateErc721PermitSignature(
     throw new Error("RPC is not defined");
   }
 
-  if (!_nftContractAddress) {
-    const errorMesage = "NFT contract address is not defined";
-    _logger.error(errorMesage);
-    throw new Error(errorMesage);
+  if (!NFT_CONTRACT_ADDRESS) {
+    const errorMessage = "NFT contract address is not defined";
+    logger.error(errorMessage);
+    throw new Error(errorMessage);
   }
 
   let provider;

tests/generate-payout-permit.test.ts

@@ -5,7 +5,6 @@ import { generatePayoutPermit } from "../src/handlers/generate-payout-permit";
 import { Context } from "../src/types/context";
 import { cypherText, mockContext, SPENDER } from "./constants";
 
-jest.mock("../src/utils/helpers");
 jest.mock("../src/handlers/generate-erc20-permit");
 jest.mock("../src/handlers/generate-erc721-permit");