Permits #2
Permits #2
Conversation
Coverage Report (0%)
|
| @@ -40,7 +37,7 @@ | |||
| "blake2b": "^2.1.4", | |||
| "decimal.js": "^10.4.3", | |||
| "dotenv": "^16.4.4", | |||
| "ethers": "^5.7.2", | |||
| "ethers": "^6.11.1", | |||
There was a problem hiding this comment.
This is a breaking change and I recall that it really changes the API I hope you did this for good reason!
There was a problem hiding this comment.
5.x seems to be marked legacy so eventually we should bump it up but right now that breaks the code, as it is in the latest commit of that branch.
| const { type, amount, username, contributionType } = permitRequest; | ||
|
|
||
| let permit: Permit; | ||
| switch (type) { |
There was a problem hiding this comment.
I think it's fine, if eventually we want to have more permits? It's always better to have a switch case than an if 🌲 forest.
There was a problem hiding this comment.
We don't have any plans for different types of permits
| @@ -40,7 +37,7 @@ | |||
| "blake2b": "^2.1.4", | |||
| "decimal.js": "^10.4.3", | |||
| "dotenv": "^16.4.4", | |||
| "ethers": "^5.7.2", | |||
| "ethers": "^6.11.1", | |||
There was a problem hiding this comment.
5.x seems to be marked legacy so eventually we should bump it up but right now that breaks the code, as it is in the latest commit of that branch.
| @@ -30,7 +30,7 @@ jobs: | |||
| node-version: "20.10.0" | |||
|
|
|||
| - name: Install dependencies | |||
| run: yarn | |||
| run: npm install -g bun && bun install | |||
There was a problem hiding this comment.
This can directly be used within https://bun.sh/guides/runtime/cicd
However I don't see where bun is used?
| const { type, amount, username, contributionType } = permitRequest; | ||
|
|
||
| let permit: Permit; | ||
| switch (type) { |
There was a problem hiding this comment.
I think it's fine, if eventually we want to have more permits? It's always better to have a switch case than an if 🌲 forest.
No description provided.